Ticket #2 (closed task: fixed)

Opened 2 years ago

Last modified 1 year ago

game

Reported by: evilbunny Assigned to: evilbunny
Priority: trivial Component: MIDlet
Keywords: game Cc: painting

Description (Last modified by evilbunny)

there is a mistake in your changes: You stores 2 values in the config file freeauth.conf, but when calling the pam module, you change the 3rd value (after skipping the 1nd and 2nd):

<SNIP>
      pos -= strlen(buffer);
      p=buffer;
      while ( p && (! isspace(*p)) ) p++;  // skip name
      while ( p &&    isspace(*p)  ) p++;  // skip gap
      while ( p && (! isspace(*p)) ) p++;  // skip secret
      while ( p &&    isspace(*p)  ) p++;  // skip gap
      pos += (p-buffer);
</SNIP>

<SNIP>
  for (;pos--;) if (fgetc(fp)==EOF) return PAM_PERM_DENIED;
  fflush(fp);
  if ( fputs(SECRET,fp) == EOF ) return PAM_PERM_DENIED;
</SNIP>

You have to remove the lines to skip the secret:

<SNIP>
      pos -= strlen(buffer);
      p=buffer;
      while ( p && (! isspace(*p)) ) p++;  // skip name
      while ( p &&    isspace(*p)  ) p++;  // skip gap
      pos += (p-buffer);
</SNIP>

Attachments

Change History

03/12/07 12:58:09 changed by evilbunny

  • description changed.

03/12/07 18:43:18 changed by evilbunny

  • status changed from new to assigned.

I've made the above changes and tried to test but the passwd util seems to be using passwd/shadow files, not PAM...

03/12/07 19:21:00 changed by evilbunny

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed this bug, checked changes into SVN

07/07/07 11:25:24 changed by anonymous

  • cc set to painting.
  • component changed from pam_freeauth to MIDlet.
  • summary changed from Code changes needed in pam_freeauth to update shared secret. to painting.
  • priority changed from major to trivial.
  • keywords set to painting.
  • type changed from defect to task.

07/07/07 12:29:40 changed by anonymous

  • priority changed from trivial to critical.
  • component changed from MIDlet to EMS.

07/11/07 20:57:44 changed by anonymous

  • keywords changed from painting to game.
  • priority changed from critical to trivial.
  • component changed from EMS to MIDlet.
  • summary changed from painting to game.

Add/Change #2 (game)




Change Properties
Action